Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use packagePath to compute internal functions directories #5944

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

eduardoboucas
Copy link
Member

Summary

The recent monorepo changes were missing the packagePath property when computing the internal functions directories, so functions were being placed at the repository root and not in the package path. This broke deployments.

@eduardoboucas eduardoboucas requested a review from a team as a code owner August 11, 2023 17:12
@eduardoboucas eduardoboucas marked this pull request as draft August 11, 2023 17:12
@github-actions
Copy link

📊 Benchmark results

Comparing with c0bec84

  • Dependency count: 1,313 (no change)
  • Package size: 271 MB ⬇️ 0.00% decrease vs. c0bec84

@lukasholzer lukasholzer merged commit 43ce9cc into main Aug 14, 2023
64 checks passed
@lukasholzer lukasholzer deleted the fix/monorepo-deploy branch August 14, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants